-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
follow-up for fabric-scoped event #22014
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/follow_up_undefined_fabric_event
Aug 22, 2022
Merged
follow-up for fabric-scoped event #22014
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/follow_up_undefined_fabric_event
Aug 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
August 18, 2022 18:30
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
August 18, 2022 18:30
PR #22014: Size comparison from 3acafb1 to a09f6ca Increases (18 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, telink)
Decreases (7 builds for cc13x2_26x2, psoc6)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
yunhanw-google
force-pushed
the
feature/follow_up_undefined_fabric_event
branch
from
August 18, 2022 23:07
a09f6ca
to
984247e
Compare
PR #22014: Size comparison from c9d2148 to 984247e Increases (20 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, telink)
Decreases (4 builds for cc13x2_26x2)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
yunhanw-google
force-pushed
the
feature/follow_up_undefined_fabric_event
branch
from
August 19, 2022 00:30
984247e
to
671ac48
Compare
PR #22014: Size comparison from 2a5f7fe to 671ac48 Increases (18 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
yunhanw-google
force-pushed
the
feature/follow_up_undefined_fabric_event
branch
from
August 19, 2022 04:53
671ac48
to
35cc5a6
Compare
PR #22014: Size comparison from 3f69587 to 35cc5a6 Increases (19 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, telink)
Decreases (6 builds for cc13x2_26x2, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
yunhanw-google
force-pushed
the
feature/follow_up_undefined_fabric_event
branch
from
August 19, 2022 06:30
35cc5a6
to
f498e3d
Compare
PR #22014: Size comparison from 3f69587 to f498e3d Increases (18 builds for bl602, cc13x2_26x2, cyw30739, esp32, k32w, nrfconnect, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
mrjerryjohns
approved these changes
Aug 19, 2022
jmartinez-silabs
approved these changes
Aug 22, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
follow-up for fabric-scoped event
Change overview
Return the error when logging fabric scoped event and fabric is undefined.
Fix the test
Testing
Fix the test that validated the fabric-scoped event cannot be logged when fabric is undefined.